More or less, yes.
I see that it has been formatted. Thanks.
Are you able to fixed the dev_tests compilation error too? Not that it is critical. But it would be good we could run some dev tests on it and it is nicer for others to download and compile. I will look into the Windows wallet.
[ 99%] Building CXX object tests/CMakeFiles/dev_tests.dir/dev_tests.cpp.o
In file included from /root/ab/PTS/libraries/wallet/include/bts/wallet/transaction_builder.hpp:5:0,
from /root/ab/PTS/libraries/wallet/include/bts/wallet/wallet.hpp:6,
from /root/ab/PTS/tests/dev_fixture.hpp:3,
from /root/ab/PTS/tests/dev_tests.cpp:3:
/root/ab/PTS/libraries/wallet/include/bts/wallet/wallet_records.hpp: In member function âbool bts::wallet::transaction_ledger_entry::is_confirmed() constâ:
/root/ab/PTS/libraries/wallet/include/bts/wallet/wallet_records.hpp:203:56: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
bool is_confirmed()const { return block_num != -1; }
^
In file included from /root/ab/PTS/tests/dev_tests.cpp:3:0:
/root/ab/PTS/tests/dev_fixture.hpp: In constructor âchain_fixture::chain_fixture()â:
/root/ab/PTS/tests/dev_fixture.hpp:166:61: error: âBTS_BLOCKCHAIN_INITIAL_SHARESâ was not declared in this scope
(double)BTS_BLOCKCHAIN_INITIAL_SHARES/BTS_BLOCKCHAIN_NUM_DELEGATES) );
^
make[2]: *** [tests/CMakeFiles/dev_tests.dir/dev_tests.cpp.o] Error 1
make[1]: *** [tests/CMakeFiles/dev_tests.dir/all] Error 2
