PTS forked and testnet

[cube]

Hi guys,

I like to let you know that we have forked PTS and a first-cut linux command-line client is ready for testnet.   

https://github.com/bigcube/PTS

The P2P port for testnet is 3700 and live network 3777.

We need volunteers to provide seed nodes (for both testnets and live net), delegates and testing.   Please feel free to make fixes and send pull requests.

[amencon]

Excellent, thanks cube.  I'll try to get a test client up soon, hopefully tonight.

[pc]

I like to let you know that we have forked PTS and a first-cut linux command-line client is ready for testnet.   

https://github.com/bigcube/PTS

The P2P port for testnet is 3700 and live network 3777.

Great! Although I can't build this. It looks like your commit of libraries/fc is incomplete (my cmake invocation fails to find GetGitRevisionDescription for example). Any reason why you committed the actual fc library itself and not a submodule?

[cube]

I like to let you know that we have forked PTS and a first-cut linux command-line client is ready for testnet.   

https://github.com/bigcube/PTS

The P2P port for testnet is 3700 and live network 3777.

Great! Although I can't build this. It looks like your commit of libraries/fc is incomplete (my cmake invocation fails to find GetGitRevisionDescription for example). Any reason why you committed the actual fc library itself and not a submodule?

Errm.. because I am not familiar with github.  This is the first time I am using it  

The codes are compiled in and works with ubuntu 14.04. 

I got to find out more about this submodule thing.  Please feel free to upload/update the submodule if you know the way though. 

[pc]

Well, I'm also only vaguely familiar with github.

I noticed that you seem to have created an entirely new repository and uploaded your source into it. This is bad, because there is no history available for your code. Merging fixes from the original will also be more difficult I think.

Also, your code seems to be based on an early version of KeyID/DNS, not on the original bitshares toolkit, right? I think forking the bitshares toolkit and working from that point would be a better approach.

[pc]

I found this guide on how to create a new DAC using the bitshares toolkit: https://github.com/BitShares/bitshares_toolkit/wiki/DAC-Launch-Checklist

Doesn't look too difficult. Started working on it - I'll see how far I get.

[pc]

OK, I have created a working version by forking the toolkit and using the hints from the above guide: https://github.com/pmconrad/PTS
This is the CLI client only, I haven't touched the QT wallet. Haven't even tried building it yet.
Linux packages are available at http://software.opensuse.org/download.html?project=home%3Ap_conrad%3Abts&package=BitSharesPTS .

Genesis block is based on PTS snapshot of 2014-10-30.

This is a test network. Various settings may still need tweaking. I have set the block time to 60 seconds, for example, and also a minimum TX fee of .001 PTS.

Please note that I'm not applying as a lead developer. I have just tried out what I think is a cleaner approach.

[cube]

I found this guide on how to create a new DAC using the bitshares toolkit: https://github.com/BitShares/bitshares_toolkit/wiki/DAC-Launch-Checklist

Doesn't look too difficult. Started working on it - I'll see how far I get.

I got to that too.  But got stuck whenever I wanted to change the currency symbol to "PTST" instead of "PTS", for testing purpose.

[cube]

OK, I have created a working version by forking the toolkit and using the hints from the above guide: https://github.com/pmconrad/PTS
This is the CLI client only, I haven't touched the QT wallet. Haven't even tried building it yet.
Linux packages are available at http://software.opensuse.org/download.html?project=home%3Ap_conrad%3Abts&package=BitSharesPTS .

Genesis block is based on PTS snapshot of 2014-10-30.

This is a test network. Various settings may still need tweaking. I have set the block time to 60 seconds, for example, and also a minimum TX fee of .001 PTS.

Please note that I'm not applying as a lead developer. I have just tried out what I think is a cleaner approach.

Wonderful work!  I am cloning it and trying it. 

Edit: My thought on the lead developer.  PTS DPOS is an open-source offspring from bitshare.  It is a chance for all developers who like to contribute freely and make a difference.  Let's keep the open-source spirit going high.

[cube]

I am facing some problems with codes cloned from https://github.com/pmconrad/PTS:

1) Compilation problem for dev tests.

[ 99%] Building CXX object tests/CMakeFiles/dev_tests.dir/dev_tests.cpp.o
In file included from /root/ab/PTS/libraries/wallet/include/bts/wallet/transaction_builder.hpp:5:0,
                 from /root/ab/PTS/libraries/wallet/include/bts/wallet/wallet.hpp:6,
                 from /root/ab/PTS/tests/dev_fixture.hpp:3,
                 from /root/ab/PTS/tests/dev_tests.cpp:3:
/root/ab/PTS/libraries/wallet/include/bts/wallet/wallet_records.hpp: In member function âbool bts::wallet::transaction_ledger_entry::is_confirmed() constâ:
/root/ab/PTS/libraries/wallet/include/bts/wallet/wallet_records.hpp:203:56: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
        bool is_confirmed()const { return block_num != -1; }


2)

  "blockchain_head_block_num": 0,
  "blockchain_head_block_age": null,
  "blockchain_head_block_timestamp": null,
 "network_num_connections": 0,

No connection for running bitshare_client without parameters or running the client with p2p port - eg 3700, 3701 and 3702.

It seems some problem with the new seeding codes.

Console did however mention a few peers found

"Adding peer 81.7.11.13:3701 to peer database
Adding peer 5.104.106.18:3701 to peer database"


3) I still have problem if I changed the prefix PTS to PTST.  We may need a different prefix for a Dev Chain later.

In file included from /root/ab/PTS/tests/dev_tests.cpp:3:0:
/root/ab/PTS/tests/dev_fixture.hpp: In constructor âchain_fixture::chain_fixture()â:
/root/ab/PTS/tests/dev_fixture.hpp:166:61: error: âBTS_BLOCKCHAIN_INITIAL_SHARESâ was not declared in this scope
                                                     (double)BTS_BLOCKCHAIN_INITIAL_SHARES/BTS_BLOCKCHAIN_NUM_DELEGATES) );
                                                             ^
make[2]: *** [tests/CMakeFiles/dev_tests.dir/dev_tests.cpp.o] Error 1
make[1]: *** [tests/CMakeFiles/dev_tests.dir/all] Error 2

[pc]

I am facing some problems with codes cloned from https://github.com/pmconrad/PTS:

Thanks for your feedback!

1) Compilation problem for dev tests.

[ 99%] Building CXX object tests/CMakeFiles/dev_tests.dir/dev_tests.cpp.o
In file included from /root/ab/PTS/libraries/wallet/include/bts/wallet/transaction_builder.hpp:5:0,
                 from /root/ab/PTS/libraries/wallet/include/bts/wallet/wallet.hpp:6,
                 from /root/ab/PTS/tests/dev_fixture.hpp:3,
                 from /root/ab/PTS/tests/dev_tests.cpp:3:
/root/ab/PTS/libraries/wallet/include/bts/wallet/wallet_records.hpp: In member function âbool bts::wallet::transaction_ledger_entry::is_confirmed() constâ:
/root/ab/PTS/libraries/wallet/include/bts/wallet/wallet_records.hpp:203:56: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
        bool is_confirmed()const { return block_num != -1; }

That's only a warning, and it stems from the upstream code. I admit I haven't tried building the tests.

2)

  "blockchain_head_block_num": 0,
  "blockchain_head_block_age": null,
  "blockchain_head_block_timestamp": null,
 "network_num_connections": 0,

No connection for running bitshare_client without parameters or running the client with p2p port - eg 3700, 3701 and 3702.

It seems some problem with the new seeding codes.

Console did however mention a few peers found

"Adding peer 81.7.11.13:3701 to peer database
Adding peer 5.104.106.18:3701 to peer database"

That's a firewall problem on my side, please try again.

3) I still have problem if I changed the prefix PTS to PTST.  We may need a different prefix for a Dev Chain later.

In file included from /root/ab/PTS/tests/dev_tests.cpp:3:0:
/root/ab/PTS/tests/dev_fixture.hpp: In constructor âchain_fixture::chain_fixture()â:
/root/ab/PTS/tests/dev_fixture.hpp:166:61: error: âBTS_BLOCKCHAIN_INITIAL_SHARESâ was not declared in this scope
                                                     (double)BTS_BLOCKCHAIN_INITIAL_SHARES/BTS_BLOCKCHAIN_NUM_DELEGATES) );
                                                             ^
make[2]: *** [tests/CMakeFiles/dev_tests.dir/dev_tests.cpp.o] Error 1
make[1]: *** [tests/CMakeFiles/dev_tests.dir/all] Error 2

Ah, I see. I have removed the BLOCKCHAIN_INITIAL_SHARES constant because it is used to scale the balances in genesis.json for a total of BLOCKCHAIN_INITIAL_SHARES. But I wanted to preserve the genesis balances exactly as they are, so I removed the scaling code. The test code will have to be adapted.

[cube]

The seed nodes work after you fixed the firewall. The blocks are producing too.   

Block time is at 60secs. Seems a bit slow when we are used to the 10sec speed.  What would happen if we match it to 10sec?

[pc]

The seed nodes work after you fixed the firewall. The blocks are producing too.   

Block time is at 60secs. Seems a bit slow when we are used to the 10sec speed.  What would happen if we match it to 10sec?

Yes, 60sec is too slow for the real thing. Setting it to 10 seconds should work just like with BTSX. Don't know if we need to set it that quick, we'll be just producing more blocks. Maybe 15? I'm open to suggestions.

[Riverhead]

I will have a seed/chain node up in a few hours if it builds. I'll update this post with the IP/Port info.

[pc]

I will have a seed/chain node up in a few hours if it builds. I'll update this post with the IP/Port info.

Great! Welcome to the team! :-)